Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d71d47e authored by Michal Kazior's avatar Michal Kazior Committed by Kalle Valo
Browse files

ath10k: fix tx hang 



The wake_tx_queue/push_pending logic had a bug
which could stop queues indefinitely effectivelly
breaking traffic.

Fixes: 29946878 ("ath10k: implement wake_tx_queue")
Signed-off-by: default avatarMichal Kazior <michal.kazior@tieto.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent bf031bc4

drivers/net/wireless/ath/ath10k/mac.c

+4 −4
Original line number Diff line number Diff line
@@ -3777,14 +3777,14 @@ void ath10k_mac_tx_push_pending(struct ath10k *ar) 
		}



		list_del_init(&artxq->list);

		ath10k_htt_tx_txq_update(hw, txq);



		if (artxq == last || (ret < 0 && ret != -ENOENT)) {

		if (ret != -ENOENT)

			list_add_tail(&artxq->list, &ar->txqs);



		ath10k_htt_tx_txq_update(hw, txq);



		if (artxq == last || (ret < 0 && ret != -ENOENT))

			break;

	}

	}



	rcu_read_unlock();

	spin_unlock_bh(&ar->txqs_lock);