Commit 9d5262ae authored Sep 02, 2016 by Julia Lawall Committed by Takashi Iwai Sep 02, 2016

ALSA: cs5535audio: constify snd_pcm_ops structures

Check for snd_pcm_ops structures that are only stored in the ops field of a
snd_soc_platform_driver structure or passed as the third argument to
snd_pcm_set_ops.  The corresponding field or parameter is declared const,
so snd_pcm_ops structures that have this property can be declared as const
also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct snd_pcm_ops i@p = { ... };

@ok1@
identifier r.i;
struct snd_soc_platform_driver e;
position p;
@@
e.ops = &i@p;

@ok2@
identifier r.i;
expression e1, e2;
position p;
@@
snd_pcm_set_ops(e1, e2, &i@p)

@bad@
position p != {r.p,ok1.p,ok2.p};
identifier r.i;
struct snd_pcm_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct snd_pcm_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 16f0f01d

sound/pci/cs5535audio/cs5535audio_pcm.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -380,7 +380,7 @@ static int snd_cs5535audio_capture_prepare(struct snd_pcm_substream *substream)
		substream->runtime->rate);
		}

		static struct snd_pcm_ops snd_cs5535audio_playback_ops = {
		static const struct snd_pcm_ops snd_cs5535audio_playback_ops = {
		.open = snd_cs5535audio_playback_open,
		.close = snd_cs5535audio_playback_close,
		.ioctl = snd_pcm_lib_ioctl,
		@@ -391,7 +391,7 @@ static struct snd_pcm_ops snd_cs5535audio_playback_ops = {
		.pointer = snd_cs5535audio_pcm_pointer,
		};

		static struct snd_pcm_ops snd_cs5535audio_capture_ops = {
		static const struct snd_pcm_ops snd_cs5535audio_capture_ops = {
		.open = snd_cs5535audio_capture_open,
		.close = snd_cs5535audio_capture_close,
		.ioctl = snd_pcm_lib_ioctl,