Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cc1c73a authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso
Browse files

netfilter: conntrack: avoid integer overflow when resizing 



Can overflow so we might allocate very small table when bucket count is
high on a 32bit platform.

Note: resize is only possible from init_netns.

Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 62131e5d

net/netfilter/nf_conntrack_core.c

+7 −0
Original line number Diff line number Diff line
@@ -1601,8 +1601,15 @@ void *nf_ct_alloc_hashtable(unsigned int *sizep, int nulls) 
	unsigned int nr_slots, i;

	size_t sz;



	if (*sizep > (UINT_MAX / sizeof(struct hlist_nulls_head)))

		return NULL;



	BUILD_BUG_ON(sizeof(struct hlist_nulls_head) != sizeof(struct hlist_head));

	nr_slots = *sizep = roundup(*sizep, PAGE_SIZE / sizeof(struct hlist_nulls_head));



	if (nr_slots > (UINT_MAX / sizeof(struct hlist_nulls_head)))

		return NULL;



	sz = nr_slots * sizeof(struct hlist_nulls_head);

	hash = (void *)__get_free_pages(GFP_KERNEL | __GFP_NOWARN | __GFP_ZERO,

					get_order(sz));