Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9c236753 authored by Damien Lespiau's avatar Damien Lespiau Committed by Daniel Vetter
Browse files

drm/i915/skl: Use a more idomatic early return 



We can coalesce the WARN() condition with the WARN() itself and, as we
are returning early, we can de-intent the rest of the function.

Signed-off-by: default avatarDamien Lespiau <damien.lespiau@intel.com>
Reviewed-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 318bd821

drivers/gpu/drm/i915/intel_ddi.c

+59 −62
Original line number Diff line number Diff line
@@ -1193,11 +1193,10 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */, 
		}

	}



	if (min_dco_index > 2) {

		WARN(1, "No valid parameters found for pixel clock: %dHz\n",

		     clock);

	if (WARN(min_dco_index > 2,

		 "No valid parameters found for pixel clock: %dHz\n", clock))

		return false;

	} else {



	wrpll_params->central_freq = dco_central_freq[min_dco_index];



	switch (dco_central_freq[min_dco_index]) {
@@ -1262,8 +1261,6 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */, 
		div_u64(((div_u64(dco_freq, 24) -

			  wrpll_params->dco_integer * MHz(1)) * 0x8000), MHz(1));



	}



	return true;

}