Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9c1b2808 authored by Bob Peterson's avatar Bob Peterson
Browse files

GFS2: Clear gl_object if gfs2_create_inode fails 



If function gfs2_create_inode fails after the inode has been
created (for example, if the inode_refresh fails for some reason)
the function was setting gl_object but never clearing it again.
The glocks are left pointing to a freed inode. This patch adds
the calls to clear gl_object in the appropriate error paths.

Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Reviewed-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent 4d7c18c7

fs/gfs2/inode.c

+4 −1
Original line number Diff line number Diff line
@@ -775,14 +775,17 @@ static int gfs2_create_inode(struct inode *dir, struct dentry *dentry, 
	return error;



fail_gunlock3:

	glock_clear_object(io_gl, ip);

	gfs2_glock_dq_uninit(&ip->i_iopen_gh);

	gfs2_glock_put(io_gl);

fail_gunlock2:

	if (io_gl)

		clear_bit(GLF_INODE_CREATING, &io_gl->gl_flags);

fail_free_inode:

	if (ip->i_gl)

	if (ip->i_gl) {

		glock_clear_object(ip->i_gl, ip);

		gfs2_glock_put(ip->i_gl);

	}

	gfs2_rsqa_delete(ip, NULL);

fail_free_acls:

	if (default_acl)