Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9be32181 authored by Markus Elfring's avatar Markus Elfring Committed by Martin K. Petersen
Browse files

lpfc: Delete unnecessary checks before the function call "mempool_destroy" 



The mempool_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarJames Smart <james.smart@avagotech.com>
Reviewed-by: default avatarHannes Reinicke <hare@suse.de>
Reviewed-by: default avatarSebastian Herbszt <herbszt@gmx.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 448193b5

drivers/scsi/lpfc/lpfc_mem.c

+2 −4
Original line number Diff line number Diff line
@@ -231,15 +231,13 @@ lpfc_mem_free(struct lpfc_hba *phba) 
	if (phba->lpfc_hbq_pool)

		pci_pool_destroy(phba->lpfc_hbq_pool);

	phba->lpfc_hbq_pool = NULL;



	if (phba->rrq_pool)

	mempool_destroy(phba->rrq_pool);

	phba->rrq_pool = NULL;



	/* Free NLP memory pool */

	mempool_destroy(phba->nlp_mem_pool);

	phba->nlp_mem_pool = NULL;

	if (phba->sli_rev == LPFC_SLI_REV4 && phba->active_rrq_pool) {

	if (phba->sli_rev == LPFC_SLI_REV4) {

		mempool_destroy(phba->active_rrq_pool);

		phba->active_rrq_pool = NULL;

	}