Commit 9b9e207b authored May 19, 2020 by Miquel Raynal Committed by Greg Kroah-Hartman Jun 25, 2020

mtd: rawnand: sharpsl: Fix the probe error path



[ Upstream commit 0f44b3275b3798ccb97a2f51ac85871c30d6fbbc ]

nand_release() is supposed be called after MTD device registration.
Here, only nand_scan() happened, so use nand_cleanup() instead.

There is no Fixes tag applying here as the use of nand_release()
in this driver predates by far the introduction of nand_cleanup() in
commit d44154f9 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
which makes this change possible. However, pointing this commit as the
culprit for backporting purposes makes sense.

Fixes: d44154f9 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-49-miquel.raynal@bootlin.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f92c582d

drivers/mtd/nand/raw/sharpsl.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -187,7 +187,7 @@ static int sharpsl_nand_probe(struct platform_device *pdev)
	return 0;		return 0;

	err_add:		err_add:
	nand_release(this);		nand_cleanup(this);

	err_scan:		err_scan:
	iounmap(sharpsl->io);		iounmap(sharpsl->io);