Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b5d1c29 authored by Adrian Hunter's avatar Adrian Hunter Committed by Arnaldo Carvalho de Melo
Browse files

perf tools: Disallow PMU events intel_pt and intel_bts until there is support 



Disallow PMU events intel_pt and intel_bts until the tools support them.

By default any PMU is selectable as an event but until the tools have
intel_pt and intel_bts support using them would result in no data being
recorded without any indication as to why.

Before the change:

    $ perf record -e intel_bts// sleep 1
    [ perf record: Woken up 1 times to write data ]
    [ perf record: Captured and wrote 0.008 MB perf.data ]
    $ perf report --stdio
    Error:
    The perf.data file has no samples!

After the change:

    $ perf record -e intel_bts// sleep 1
    invalid or unsupported event: 'intel_bts//'
    Run 'perf list' for a list of valid events

Reported-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1432295653-13989-2-git-send-email-adrian.hunter@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 2f80dd44

tools/perf/util/pmu.c

+4 −0
Original line number Diff line number Diff line
@@ -442,6 +442,10 @@ static struct perf_pmu *pmu_lookup(const char *name) 
	LIST_HEAD(aliases);

	__u32 type;



	/* No support for intel_bts or intel_pt so disallow them */

	if (!strcmp(name, "intel_bts") || !strcmp(name, "intel_pt"))

		return NULL;



	/*

	 * The pmu data we store & need consists of the pmu

	 * type value and format definitions. Load both right