Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b5cd132 authored by Martin K. Petersen's avatar Martin K. Petersen Committed by James Bottomley
Browse files

[SCSI] mpt2sas: Return the correct sense key for DIF errors 



Only a target device should return ABORTED COMMAND when a PI error is
discovered. The HBA should always set the sense key to ILLEGAL REQUEST.

Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Acked-by: default avatar"Sreekanth Reddy" <Sreekanth.reddy@lsi.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent d974e426

drivers/scsi/mpt2sas/mpt2sas_scsih.c

+2 −12
Original line number Diff line number Diff line
@@ -3772,8 +3772,6 @@ static void 
_scsih_eedp_error_handling(struct scsi_cmnd *scmd, u16 ioc_status)

{

	u8 ascq;

	u8 sk;

	u8 host_byte;



	switch (ioc_status) {

	case MPI2_IOCSTATUS_EEDP_GUARD_ERROR:
@@ -3790,16 +3788,8 @@ _scsih_eedp_error_handling(struct scsi_cmnd *scmd, u16 ioc_status) 
		break;

	}



	if (scmd->sc_data_direction == DMA_TO_DEVICE) {

		sk = ILLEGAL_REQUEST;

		host_byte = DID_ABORT;

	} else {

		sk = ABORTED_COMMAND;

		host_byte = DID_OK;

	}



	scsi_build_sense_buffer(0, scmd->sense_buffer, sk, 0x10, ascq);

	scmd->result = DRIVER_SENSE << 24 | (host_byte << 16) |

	scsi_build_sense_buffer(0, scmd->sense_buffer, ILLEGAL_REQUEST, 0x10, ascq);

	scmd->result = DRIVER_SENSE << 24 | (DID_ABORT << 16) |

	    SAM_STAT_CHECK_CONDITION;

}