Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b17512d authored by Yan, Zheng's avatar Yan, Zheng Committed by Greg Kroah-Hartman
Browse files

ceph: hold i_ceph_lock when removing caps for freeing inode 



commit d6e47819721ae2d9d090058ad5570a66f3c42e39 upstream.

ceph_d_revalidate(, LOOKUP_RCU) may call __ceph_caps_issued_mask()
on a freeing inode.

Signed-off-by: default avatar"Yan, Zheng" <zyan@redhat.com>
Reviewed-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b6c3b6a2

fs/ceph/caps.c

+5 −2
Original line number Diff line number Diff line
@@ -1237,20 +1237,23 @@ static int send_cap_msg(struct cap_msg_args *arg) 
}



/*

 * Queue cap releases when an inode is dropped from our cache.  Since

 * inode is about to be destroyed, there is no need for i_ceph_lock.

 * Queue cap releases when an inode is dropped from our cache.

 */

void ceph_queue_caps_release(struct inode *inode)

{

	struct ceph_inode_info *ci = ceph_inode(inode);

	struct rb_node *p;



	/* lock i_ceph_lock, because ceph_d_revalidate(..., LOOKUP_RCU)

	 * may call __ceph_caps_issued_mask() on a freeing inode. */

	spin_lock(&ci->i_ceph_lock);

	p = rb_first(&ci->i_caps);

	while (p) {

		struct ceph_cap *cap = rb_entry(p, struct ceph_cap, ci_node);

		p = rb_next(p);

		__ceph_remove_cap(cap, true);

	}

	spin_unlock(&ci->i_ceph_lock);

}



/*