Commit 9b15350f authored Jun 08, 2016 by Florian Westphal Committed by David S. Miller Jun 08, 2016

qfq: don't leak skb if kzalloc fails



When we need to create a new aggregate to enqueue the skb we call kzalloc.
If that fails we returned ENOBUFS without freeing the skb.

Spotted during code review.

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0a46baaf

net/sched/sch_qfq.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1235,8 +1235,10 @@ static int qfq_enqueue(struct sk_buff skb, struct Qdisc sch)
		cl->agg->lmax, qdisc_pkt_len(skb), cl->common.classid);
		err = qfq_change_agg(sch, cl, cl->agg->class_weight,
		qdisc_pkt_len(skb));
		if (err)
		return err;
		if (err) {
		cl->qstats.drops++;
		return qdisc_drop(skb, sch);
		}
		}

		err = qdisc_enqueue(skb, cl->qdisc);