Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9adfe5c8 authored by Daniel Vetter's avatar Daniel Vetter Committed by Lee Jones
Browse files

staging: fbtft: Stop using BL_CORE_DRIVER1 



Leaking driver internal tracking into the already massively confusing
backlight power tracking is really confusing.

Luckily we have already a drvdata structure, so fixing this is really
easy.

Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Acked-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 832ae8e0

drivers/staging/fbtft/fbtft-core.c

+2 −2
Original line number Diff line number Diff line
@@ -246,7 +246,7 @@ static int fbtft_request_gpios_dt(struct fbtft_par *par) 
static int fbtft_backlight_update_status(struct backlight_device *bd)

{

	struct fbtft_par *par = bl_get_data(bd);

	bool polarity = !!(bd->props.state & BL_CORE_DRIVER1);

	bool polarity = par->polarity;



	fbtft_par_dbg(DEBUG_BACKLIGHT, par,

		"%s: polarity=%d, power=%d, fb_blank=%d\n",
@@ -296,7 +296,7 @@ void fbtft_register_backlight(struct fbtft_par *par) 
	/* Assume backlight is off, get polarity from current state of pin */

	bl_props.power = FB_BLANK_POWERDOWN;

	if (!gpio_get_value(par->gpio.led[0]))

		bl_props.state |= BL_CORE_DRIVER1;

		par->polarity = true;



	bd = backlight_device_register(dev_driver_string(par->info->device),

				       par->info->device, par,

drivers/staging/fbtft/fbtft.h

+1 −0
Original line number Diff line number Diff line
@@ -229,6 +229,7 @@ struct fbtft_par { 
	ktime_t update_time;

	bool bgr;

	void *extra;

	bool polarity;

};



#define NUMARGS(...)  (sizeof((int[]){__VA_ARGS__})/sizeof(int))