Commit 9aa66382 authored Jun 23, 2015 by Nikolay Aleksandrov Committed by David S. Miller Jun 24, 2015

bridge: multicast: add a comment to br_port_state_selection about blocking state

Add a comment to explain why we're not disabling port's multicast when it
goes in blocking state. Since there's a check in the timer's function which
bypasses the timer if the port's in blocking/disabled state, the timer will
simply expire and stop without sending more queries.

Suggested-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3a07bd6f

net/bridge/br_stp.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -463,6 +463,10 @@ void br_port_state_selection(struct net_bridge *br)

		if (p->state != BR_STATE_BLOCKING)
		br_multicast_enable_port(p);
		/* Multicast is not disabled for the port when it goes in
		* blocking state because the timers will expire and stop by
		* themselves without sending more queries.
		*/
		if (p->state == BR_STATE_FORWARDING)
		++liveports;
		}