Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a32144e authored by Arjan van de Ven's avatar Arjan van de Ven Committed by Linus Torvalds
Browse files

[PATCH] mark struct file_operations const 7 



Many struct file_operations in the kernel can be "const".  Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data.  In addition it'll catch accidental writes at compile time to
these shared resources.

Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 00977a59

ipc/mqueue.c

+2 −2
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ struct mqueue_inode_info { 
};



static struct inode_operations mqueue_dir_inode_operations;

static struct file_operations mqueue_file_operations;

static const struct file_operations mqueue_file_operations;

static struct super_operations mqueue_super_ops;

static void remove_notification(struct mqueue_inode_info *info);
@@ -1166,7 +1166,7 @@ static struct inode_operations mqueue_dir_inode_operations = { 
	.unlink = mqueue_unlink,

};



static struct file_operations mqueue_file_operations = {

static const struct file_operations mqueue_file_operations = {

	.flush = mqueue_flush_file,

	.poll = mqueue_poll_file,

	.read = mqueue_read_file,

ipc/shm.c

+2 −2
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ 


#include "util.h"



static struct file_operations shm_file_operations;

static const struct file_operations shm_file_operations;

static struct vm_operations_struct shm_vm_ops;



static struct ipc_ids init_shm_ids;
@@ -249,7 +249,7 @@ static int shm_release(struct inode *ino, struct file *file) 
	return 0;

}



static struct file_operations shm_file_operations = {

static const struct file_operations shm_file_operations = {

	.mmap		= shm_mmap,

	.release	= shm_release,

#ifndef CONFIG_MMU

ipc/util.c

+2 −2
Original line number Diff line number Diff line
@@ -205,7 +205,7 @@ void __ipc_init ipc_init_ids(struct ipc_ids* ids, int size) 
}



#ifdef CONFIG_PROC_FS

static struct file_operations sysvipc_proc_fops;

static const struct file_operations sysvipc_proc_fops;

/**

 *	ipc_init_proc_interface	-  Create a proc interface for sysipc types using a seq_file interface.

 *	@path: Path in procfs
@@ -879,7 +879,7 @@ static int sysvipc_proc_release(struct inode *inode, struct file *file) 
	return seq_release_private(inode, file);

}



static struct file_operations sysvipc_proc_fops = {

static const struct file_operations sysvipc_proc_fops = {

	.open    = sysvipc_proc_open,

	.read    = seq_read,

	.llseek  = seq_lseek,

kernel/cpuset.c

+1 −1
Original line number Diff line number Diff line
@@ -2656,7 +2656,7 @@ static int cpuset_open(struct inode *inode, struct file *file) 
	return single_open(file, proc_cpuset_show, pid);

}



struct file_operations proc_cpuset_operations = {

const struct file_operations proc_cpuset_operations = {

	.open		= cpuset_open,

	.read		= seq_read,

	.llseek		= seq_lseek,

net/802/tr.c

+1 −1
Original line number Diff line number Diff line
@@ -576,7 +576,7 @@ static int rif_seq_open(struct inode *inode, struct file *file) 
	return seq_open(file, &rif_seq_ops);

}



static struct file_operations rif_seq_fops = {

static const struct file_operations rif_seq_fops = {

	.owner	 = THIS_MODULE,

	.open    = rif_seq_open,

	.read    = seq_read,