Commit 99fe29d3 authored Mar 28, 2018 by Dan Carpenter Committed by David S. Miller Mar 29, 2018

test_bpf: Fix NULL vs IS_ERR() check in test_skb_segment()



The skb_segment() function returns error pointers on error.  It never
returns NULL.

Fixes: 76db8087 ("net: bpf: add a test for skb_segment in test_bpf module")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Yonghong Song <yhs@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 981f1f80

lib/test_bpf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6649,7 +6649,7 @@ static __init int test_skb_segment(void)
		}

		segs = skb_segment(skb, features);
		if (segs) {
		if (!IS_ERR(segs)) {
		kfree_skb_list(segs);
		ret = 0;
		pr_info("%s: success in skb_segment!", __func__);