Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 99e5cde5 authored by Johan Hovold's avatar Johan Hovold Committed by Michael Ellerman
Browse files

powerpc/pci/rpadlpar: Fix device reference leaks 



Make sure to drop any device reference taken by vio_find_node() when
adding and removing virtual I/O slots.

Fixes: 5eeb8c63 ("[PATCH] PCI Hotplug: rpaphp: Move VIO registration")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent e8cfb7e7

drivers/pci/hotplug/rpadlpar_core.c

+9 −1
Original line number Diff line number Diff line
@@ -257,8 +257,13 @@ static int dlpar_add_phb(char *drc_name, struct device_node *dn) 


static int dlpar_add_vio_slot(char *drc_name, struct device_node *dn)

{

	if (vio_find_node(dn))

	struct vio_dev *vio_dev;



	vio_dev = vio_find_node(dn);

	if (vio_dev) {

		put_device(&vio_dev->dev);

		return -EINVAL;

	}



	if (!vio_register_device_node(dn)) {

		printk(KERN_ERR
@@ -334,6 +339,9 @@ static int dlpar_remove_vio_slot(char *drc_name, struct device_node *dn) 
		return -EINVAL;



	vio_unregister_device(vio_dev);



	put_device(&vio_dev->dev);



	return 0;

}