Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 99cd1242 authored by Chiranjeevi Rapolu's avatar Chiranjeevi Rapolu Committed by Mauro Carvalho Chehab
Browse files

[media] media: ov5670: Use recommended black level and output bias 



Previously, images were relatively darker due to non-optimal
settings for black target level and bias.

Now, use recommended settings for black target level and output bias
as default values. The same default settings apply to all the resolutions.
Given these recommeneded settings do not change dynamically, add these to
existing mode register settings.

Signed-off-by: default avatarChiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent cecfe9b8

drivers/media/i2c/ov5670.c

+24 −6
Original line number Original line Diff line number Diff line
@@ -390,7 +390,10 @@ static const struct ov5670_reg mode_2592x1944_regs[] = { 
	{0x5792, 0x00},

	{0x5792, 0x00},

	{0x5793, 0x52},

	{0x5793, 0x52},

	{0x5794, 0xa3},

	{0x5794, 0xa3},

	{0x3503, 0x00}

	{0x3503, 0x00},

	{0x5045, 0x05},

	{0x4003, 0x40},

	{0x5048, 0x40}

};

};





static const struct ov5670_reg mode_1296x972_regs[] = {

static const struct ov5670_reg mode_1296x972_regs[] = {
@@ -653,7 +656,10 @@ static const struct ov5670_reg mode_1296x972_regs[] = { 
	{0x5792, 0x00},

	{0x5792, 0x00},

	{0x5793, 0x52},

	{0x5793, 0x52},

	{0x5794, 0xa3},

	{0x5794, 0xa3},

	{0x3503, 0x00}

	{0x3503, 0x00},

	{0x5045, 0x05},

	{0x4003, 0x40},

	{0x5048, 0x40}

};

};





static const struct ov5670_reg mode_648x486_regs[] = {

static const struct ov5670_reg mode_648x486_regs[] = {
@@ -916,7 +922,10 @@ static const struct ov5670_reg mode_648x486_regs[] = { 
	{0x5792, 0x00},

	{0x5792, 0x00},

	{0x5793, 0x52},

	{0x5793, 0x52},

	{0x5794, 0xa3},

	{0x5794, 0xa3},

	{0x3503, 0x00}

	{0x3503, 0x00},

	{0x5045, 0x05},

	{0x4003, 0x40},

	{0x5048, 0x40}

};

};





static const struct ov5670_reg mode_2560x1440_regs[] = {

static const struct ov5670_reg mode_2560x1440_regs[] = {
@@ -1178,7 +1187,10 @@ static const struct ov5670_reg mode_2560x1440_regs[] = { 
	{0x5791, 0x06},

	{0x5791, 0x06},

	{0x5792, 0x00},

	{0x5792, 0x00},

	{0x5793, 0x52},

	{0x5793, 0x52},

	{0x5794, 0xa3}

	{0x5794, 0xa3},

	{0x5045, 0x05},

	{0x4003, 0x40},

	{0x5048, 0x40}

};

};





static const struct ov5670_reg mode_1280x720_regs[] = {

static const struct ov5670_reg mode_1280x720_regs[] = {
@@ -1441,7 +1453,10 @@ static const struct ov5670_reg mode_1280x720_regs[] = { 
	{0x5792, 0x00},

	{0x5792, 0x00},

	{0x5793, 0x52},

	{0x5793, 0x52},

	{0x5794, 0xa3},

	{0x5794, 0xa3},

	{0x3503, 0x00}

	{0x3503, 0x00},

	{0x5045, 0x05},

	{0x4003, 0x40},

	{0x5048, 0x40}

};

};





static const struct ov5670_reg mode_640x360_regs[] = {

static const struct ov5670_reg mode_640x360_regs[] = {
@@ -1704,7 +1719,10 @@ static const struct ov5670_reg mode_640x360_regs[] = { 
	{0x5792, 0x00},

	{0x5792, 0x00},

	{0x5793, 0x52},

	{0x5793, 0x52},

	{0x5794, 0xa3},

	{0x5794, 0xa3},

	{0x3503, 0x00}

	{0x3503, 0x00},

	{0x5045, 0x05},

	{0x4003, 0x40},

	{0x5048, 0x40}

};

};





static const char * const ov5670_test_pattern_menu[] = {

static const char * const ov5670_test_pattern_menu[] = {