Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9945cf99 authored by Shyam Saini's avatar Shyam Saini Committed by Mauro Carvalho Chehab
Browse files

[media] media: usb: cpia2: Use kmemdup instead of kmalloc and memcpy 



When some other buffer is immediately copied into allocated region.
Replace calls to kmalloc followed by a memcpy with a direct
call to kmemdup.

Signed-off-by: default avatarShyam Saini <mayhs11saini@gmail.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 01faa0d9

drivers/media/usb/cpia2/cpia2_usb.c

+1 −3
Original line number Diff line number Diff line
@@ -547,12 +547,10 @@ static int write_packet(struct usb_device *udev, 
	if (!registers || size <= 0)

		return -EINVAL;



	buf = kmalloc(size, GFP_KERNEL);

	buf = kmemdup(registers, size, GFP_KERNEL);

	if (!buf)

		return -ENOMEM;



	memcpy(buf, registers, size);



	ret = usb_control_msg(udev,

			       usb_sndctrlpipe(udev, 0),

			       request,