Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 993dc737 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Lee Jones
Browse files

mfd: omap-usb-tll: Fix register offsets 



gcc-8 notices that the register number calculation is wrong
when the offset is an 'u8' but the number is larger than 256:

drivers/mfd/omap-usb-tll.c: In function 'omap_tll_init':
drivers/mfd/omap-usb-tll.c:90:46: error: overflow in conversion from 'int' to 'u8 {aka unsigned char}' chages value from 'i * 256 + 2070' to '22' [-Werror=overflow]

This addresses it by always using a 32-bit offset number for
the register. This is apparently an old problem that previous
compilers did not find.

Fixes: 16fa3dc7 ("mfd: omap-usb-tll: HOST TLL platform driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 7e1372a4

drivers/mfd/omap-usb-tll.c

+2 −2
Original line number Diff line number Diff line
@@ -131,12 +131,12 @@ static inline u32 usbtll_read(void __iomem *base, u32 reg) 
	return readl_relaxed(base + reg);

}



static inline void usbtll_writeb(void __iomem *base, u8 reg, u8 val)

static inline void usbtll_writeb(void __iomem *base, u32 reg, u8 val)

{

	writeb_relaxed(val, base + reg);

}



static inline u8 usbtll_readb(void __iomem *base, u8 reg)

static inline u8 usbtll_readb(void __iomem *base, u32 reg)

{

	return readb_relaxed(base + reg);

}