Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 99295618 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Linus Torvalds
Browse files

efi: Fix the build with user namespaces enabled. 



When compiling efivars.c the build fails with:

   CC      drivers/firmware/efivars.o
  drivers/firmware/efivars.c: In function ‘efivarfs_get_inode’:
  drivers/firmware/efivars.c:886:31: error: incompatible types when assigning to type ‘kgid_t’ from type ‘int’
  make[2]: *** [drivers/firmware/efivars.o] Error 1
  make[1]: *** [drivers/firmware/efivars.o] Error 2

Fix the build error by removing the duplicate initialization of i_uid and
i_gid inode_init_always has already initialized them to 0.

Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ce4a9cc5

drivers/firmware/efivars.c

+0 −1
Original line number Diff line number Diff line
@@ -883,7 +883,6 @@ static struct inode *efivarfs_get_inode(struct super_block *sb, 


	if (inode) {

		inode->i_ino = get_next_ino();

		inode->i_uid = inode->i_gid = 0;

		inode->i_mode = mode;

		inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;

		switch (mode & S_IFMT) {