Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9920239c authored by Joe Perches's avatar Joe Perches Committed by David S. Miller
Browse files

drivers/isdn/hisax: Add printf format/argument verification and fix fallout 



Add __attribute__((format... to several functins
Make formats and arguments match.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1f1aaf82

drivers/isdn/hisax/avm_pci.c

+1 −1
Original line number Diff line number Diff line
@@ -314,7 +314,7 @@ hdlc_fill_fifo(struct BCState *bcs) 
			bcs->hw.hdlc.ctrl.sr.cmd |= HDLC_CMD_XME;

	}

	if ((cs->debug & L1_DEB_HSCX) && !(cs->debug & L1_DEB_HSCX_FIFO))

		debugl1(cs, "hdlc_fill_fifo %d/%ld", count, bcs->tx_skb->len);

		debugl1(cs, "hdlc_fill_fifo %d/%u", count, bcs->tx_skb->len);

	p = bcs->tx_skb->data;

	ptr = (u_int *)p;

	skb_pull(bcs->tx_skb, count);

drivers/isdn/hisax/callc.c

+2 −2
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ hisax_findcard(int driverid) 
	return (struct IsdnCardState *) 0;

}



static void

static __attribute__((format(printf, 3, 4))) void

link_debug(struct Channel *chanp, int direction, char *fmt, ...)

{

	va_list args;
@@ -1068,7 +1068,7 @@ init_d_st(struct Channel *chanp) 
	return 0;

}



static void

static __attribute__((format(printf, 2, 3))) void

callc_debug(struct FsmInst *fi, char *fmt, ...)

{

	va_list args;

drivers/isdn/hisax/hfc_2bds0.c

+2 −2
Original line number Diff line number Diff line
@@ -292,7 +292,7 @@ hfc_fill_fifo(struct BCState *bcs) 
	}

	count = GetFreeFifoBytes_B(bcs);

	if (cs->debug & L1_DEB_HSCX)

		debugl1(cs, "hfc_fill_fifo %d count(%ld/%d),%lx",

		debugl1(cs, "hfc_fill_fifo %d count(%u/%d),%lx",

			bcs->channel, bcs->tx_skb->len,

			count, current->state);

	if (count < bcs->tx_skb->len) {
@@ -719,7 +719,7 @@ hfc_fill_dfifo(struct IsdnCardState *cs) 
	}

	count = GetFreeFifoBytes_D(cs);

	if (cs->debug & L1_DEB_ISAC)

		debugl1(cs, "hfc_fill_Dfifo count(%ld/%d)",

		debugl1(cs, "hfc_fill_Dfifo count(%u/%d)",

			cs->tx_skb->len, count);

	if (count < cs->tx_skb->len) {

		if (cs->debug & L1_DEB_ISAC)

drivers/isdn/hisax/hfc_2bs0.c

+1 −1
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ hfc_fill_fifo(struct BCState *bcs) 
	    count += cs->hw.hfc.fifosize; 

	} /* L1_MODE_TRANS */

	if (cs->debug & L1_DEB_HSCX)

		debugl1(cs, "hfc_fill_fifo %d count(%ld/%d)",

		debugl1(cs, "hfc_fill_fifo %d count(%u/%d)",

			bcs->channel, bcs->tx_skb->len,

			count);

	if (count < bcs->tx_skb->len) {

drivers/isdn/hisax/hfc_pci.c

+2 −2
Original line number Diff line number Diff line
@@ -550,7 +550,7 @@ hfcpci_fill_dfifo(struct IsdnCardState *cs) 
		count += D_FIFO_SIZE;	/* count now contains available bytes */



	if (cs->debug & L1_DEB_ISAC)

		debugl1(cs, "hfcpci_fill_Dfifo count(%ld/%d)",

		debugl1(cs, "hfcpci_fill_Dfifo count(%u/%d)",

			cs->tx_skb->len, count);

	if (count < cs->tx_skb->len) {

		if (cs->debug & L1_DEB_ISAC)
@@ -681,7 +681,7 @@ hfcpci_fill_fifo(struct BCState *bcs) 
		count += B_FIFO_SIZE;	/* count now contains available bytes */



	if (cs->debug & L1_DEB_HSCX)

		debugl1(cs, "hfcpci_fill_fifo %d count(%ld/%d),%lx",

		debugl1(cs, "hfcpci_fill_fifo %d count(%u/%d),%lx",

			bcs->channel, bcs->tx_skb->len,

			count, current->state);