Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 990acea6 authored by Wei Yongjun's avatar Wei Yongjun Committed by Roland Dreier
Browse files

IB/cm: Fix missing unlock on error in cm_init_qp_rtr_attr() 



Add the missing unlock before return from function cm_init_qp_rtr_attr()
in the error handling case.

Fixes: dd5f03be ("IB/core: Ethernet L2 attributes in verbs/cm structures")
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent 2f85d24e

drivers/infiniband/core/cm.c

+3 −1
Original line number Diff line number Diff line
@@ -3526,8 +3526,10 @@ static int cm_init_qp_rtr_attr(struct cm_id_private *cm_id_priv, 
		*qp_attr_mask = IB_QP_STATE | IB_QP_AV | IB_QP_PATH_MTU |

				IB_QP_DEST_QPN | IB_QP_RQ_PSN;

		qp_attr->ah_attr = cm_id_priv->av.ah_attr;

		if (!cm_id_priv->av.valid)

		if (!cm_id_priv->av.valid) {

			spin_unlock_irqrestore(&cm_id_priv->lock, flags);

			return -EINVAL;

		}

		if (cm_id_priv->av.ah_attr.vlan_id != 0xffff) {

			qp_attr->vlan_id = cm_id_priv->av.ah_attr.vlan_id;

			*qp_attr_mask |= IB_QP_VID;