Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 984cfef0 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

regulator: pfuze100: Fix refcount leak in pfuze_parse_regulators_dt 



[ Upstream commit afaa7b933ef00a2d3262f4d1252087613fb5c06d ]

of_node_get() returns a node with refcount incremented.
Calling of_node_put() to drop the reference when not needed anymore.

Fixes: 3784b6d6 ("regulator: pfuze100: add pfuze100 regulator driver")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220511113506.45185-1-linmq006@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 30d110ca

drivers/regulator/pfuze100-regulator.c

+2 −0
Original line number Diff line number Diff line
@@ -513,6 +513,7 @@ static int pfuze_parse_regulators_dt(struct pfuze_chip *chip) 
	parent = of_get_child_by_name(np, "regulators");

	if (!parent) {

		dev_err(dev, "regulators node not found\n");

		of_node_put(np);

		return -EINVAL;

	}
@@ -542,6 +543,7 @@ static int pfuze_parse_regulators_dt(struct pfuze_chip *chip) 
	}



	of_node_put(parent);

	of_node_put(np);

	if (ret < 0) {

		dev_err(dev, "Error parsing regulator init data: %d\n",

			ret);