Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98270ab4 authored by Manish Rangankar's avatar Manish Rangankar Committed by James Bottomley
Browse files

[SCSI] qla4xxx: Fixed session destroy issue on link up-down. 



During link down, iscsid tries to do re-login to failed session. In case of
link down-up-down, LLD was sending connection login failed event to iscsid,
which is destroying the session, instead we have to continue re-login by
sending connection err event.

JIRA Key: UPSISCSI-134

Signed-off-by: default avatarManish Rangankar <manish.rangankar@qlogic.com>
Signed-off-by: default avatarVikas Chaudhary <vikas.chaudhary@qlogic.com>
Reviewed-by: default avatarMike Christie <michaelc@cs.wisc.edu>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 736cf369

drivers/scsi/qla4xxx/ql4_init.c

+16 −0
Original line number Diff line number Diff line
@@ -931,6 +931,22 @@ int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha, uint32_t fw_ddb_index, 
			break;

		}

		break;

	case DDB_DS_SESSION_FAILED:

		switch (state) {

		case DDB_DS_SESSION_ACTIVE:

		case DDB_DS_DISCOVERY:

			iscsi_conn_login_event(ddb_entry->conn,

					       ISCSI_CONN_STATE_LOGGED_IN);

			qla4xxx_update_session_conn_param(ha, ddb_entry);

			status = QLA_SUCCESS;

			break;

		case DDB_DS_SESSION_FAILED:

			iscsi_session_failure(ddb_entry->sess->dd_data,

					      ISCSI_ERR_CONN_FAILED);

			status = QLA_SUCCESS;

			break;

		}

		break;

	default:

		DEBUG2(ql4_printk(KERN_INFO, ha, "%s: Unknown Event\n",

				__func__));

drivers/scsi/qla4xxx/ql4_os.c

+5 −1
Original line number Diff line number Diff line
@@ -1158,8 +1158,12 @@ static int qla4xxx_conn_start(struct iscsi_cls_conn *cls_conn) 
		goto exit_conn_start;

	}



	if (ddb_entry->fw_ddb_device_state == DDB_DS_NO_CONNECTION_ACTIVE)

		ddb_entry->fw_ddb_device_state = DDB_DS_LOGIN_IN_PROCESS;



	DEBUG2(printk(KERN_INFO "%s: DDB state [%d]\n", __func__,

		      ddb_entry->fw_ddb_device_state));



exit_set_param:

	iscsi_conn_start(cls_conn);

	ret = 0;