Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9801d8a3 authored by J. Bruce Fields's avatar J. Bruce Fields Committed by Linus Torvalds
Browse files

[PATCH] knfsd: nfsd4: fix open permission checking 



We weren't actually checking for SHARE_ACCESS_WRITE, with the result that the
owner could open a non-writeable file for write!

Continue to allow DENY_WRITE only with write access.

Thanks to Jim Rees for reporting the bug.

Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: default avatarNeil Brown <neilb@suse.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent dc730e17

fs/nfsd/nfs4proc.c

+3 −1
Original line number Diff line number Diff line
@@ -78,8 +78,10 @@ do_open_permission(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfs 


	if (open->op_share_access & NFS4_SHARE_ACCESS_READ)

		accmode |= MAY_READ;

	if (open->op_share_deny & NFS4_SHARE_ACCESS_WRITE)

	if (open->op_share_access & NFS4_SHARE_ACCESS_WRITE)

		accmode |= (MAY_WRITE | MAY_TRUNC);

	if (open->op_share_deny & NFS4_SHARE_DENY_WRITE)

		accmode |= MAY_WRITE;



	status = fh_verify(rqstp, current_fh, S_IFREG, accmode);