Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97c6f25d authored by Simon Guo's avatar Simon Guo Committed by Michael Ellerman
Browse files

PCI/hotplug: ppc: correct a php_slot usage after free



In pnv_php_unregister_one(), pnv_php_put_slot() might kfree
php_slot structure. But there is pci_hp_deregister() after
that with php_slot reference.

This patch moves pnv_php_put_slot() to the end of function.

Signed-off-by: default avatarSimon Guo <wei.guo.simon@gmail.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 5ee573e8
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -919,8 +919,8 @@ static void pnv_php_unregister_one(struct device_node *dn)
		return;

	php_slot->state = PNV_PHP_STATE_OFFLINE;
	pnv_php_put_slot(php_slot);
	pci_hp_deregister(&php_slot->slot);
	pnv_php_put_slot(php_slot);
}

static void pnv_php_unregister(struct device_node *dn)