Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97a70b14 authored by Mark Salter's avatar Mark Salter Committed by David Howells
Browse files

MN10300: ttySM: clean up unnecessary casting 



The ttySM uart data register pointers are declared as void* pointers. Change
them to u8* pointers so we don't need to use casts in the code.

Signed-off-by: default avatarMark Salter <msalter@redhat.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent 8f0bcbca

arch/mn10300/kernel/mn10300-serial.c

+4 −4
Original line number Diff line number Diff line
@@ -1629,12 +1629,12 @@ static void mn10300_serial_console_write(struct console *co, 


		while (*port->_status & SC01STR_TBF)

			continue;

		*(u8 *) port->_txb = ch;

		*port->_txb = ch;



		if (ch == 0x0a) {

			while (*port->_status & SC01STR_TBF)

				continue;

			*(u8 *) port->_txb = 0xd;

			*port->_txb = 0xd;

		}

	}
@@ -1759,12 +1759,12 @@ static void mn10300_serial_poll_put_char(struct uart_port *_port, 
	tmp = *port->_intr;



	if (ch == 0x0a) {

		*(u8 *) port->_txb = 0x0d;

		*port->_txb = 0x0d;

		while (*port->_status & SC01STR_TBF)

			continue;

	}



	*(u8 *) port->_txb = ch;

	*port->_txb = ch;

	while (*port->_status & SC01STR_TBF)

		continue;

arch/mn10300/kernel/mn10300-serial.h

+2 −2
Original line number Diff line number Diff line
@@ -58,8 +58,8 @@ struct mn10300_serial_port { 
	volatile u16		*_control;	/* control register pointer */

	volatile u8		*_status;	/* status register pointer */

	volatile u8		*_intr;		/* interrupt register pointer */

	volatile void		*_rxb;		/* receive buffer register pointer */

	volatile void		*_txb;		/* transmit buffer register pointer */

	volatile u8		*_rxb;		/* receive buffer register pointer */

	volatile u8		*_txb;		/* transmit buffer register pointer */

	volatile u16		*_tmicr;	/* timer interrupt control register */

	volatile u8		*_tmxmd;	/* baud rate timer mode register */

	volatile u16		*_tmxbr;	/* baud rate timer base register */