Commit 97398612 authored May 03, 2016 by Dan Carpenter Committed by Greg Kroah-Hartman May 03, 2016

usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP()



In the original DWC3_DCFG_NUMP() was always zero.  It looks like the
intent was to shift first and then do the mask.

Fixes: 2a58f9c1 ('usb: dwc3: gadget: disable automatic calculation of ACK TP NUMP')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 88a0044e

drivers/usb/dwc3/core.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -277,7 +277,7 @@
		#define DWC3_DCFG_FULLSPEED1 (3 << 0)

		#define DWC3_DCFG_NUMP_SHIFT 17
		#define DWC3_DCFG_NUMP(n) (((n) & 0x1f) >> DWC3_DCFG_NUMP_SHIFT)
		#define DWC3_DCFG_NUMP(n) (((n) >> DWC3_DCFG_NUMP_SHIFT) & 0x1f)
		#define DWC3_DCFG_NUMP_MASK (0x1f << DWC3_DCFG_NUMP_SHIFT)
		#define DWC3_DCFG_LPM_CAP (1 << 22)