Commit 96f05be3 authored Apr 13, 2015 by Takashi Iwai Committed by Mark Brown Apr 15, 2015

ASoC: qcom: Return an error for invalid PCM trigger command



Fix a compile warning
  sound/soc/qcom/lpass-cpu.c: In function ‘lpass_cpu_daiops_trigger’:
  sound/soc/qcom/lpass-cpu.c:224:2: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    return ret;
      ^
Although switch () lists the most of existing cases, it's still better
to cover the rest as an error properly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Kenneth Westfield <kwestfie@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 7667428f

sound/soc/qcom/lpass-cpu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -194,7 +194,7 @@ static int lpass_cpu_daiops_trigger(struct snd_pcm_substream *substream,
		int cmd, struct snd_soc_dai *dai)
		{
		struct lpass_data *drvdata = snd_soc_dai_get_drvdata(dai);
		int ret;
		int ret = -EINVAL;

		switch (cmd) {
		case SNDRV_PCM_TRIGGER_START: