Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96cd7962 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: caiaq: Add yet more sanity checks for invalid EPs 



A few other places in caiaq driver have the URB handling with the
fixed endpoints without checking the validity, too.  Add the sanity
check with the new helper function at each appropriate place for
avoiding the spurious kernel warnings due to invalid EPs.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 5935b952

sound/usb/caiaq/input.c

+9 −0
Original line number Diff line number Diff line
@@ -718,6 +718,9 @@ int snd_usb_caiaq_input_init(struct snd_usb_caiaqdev *cdev) 
				  usb_rcvbulkpipe(usb_dev, 0x4),

				  cdev->ep4_in_buf, EP4_BUFSIZE,

				  snd_usb_caiaq_ep4_reply_dispatch, cdev);

		ret = usb_urb_ep_type_check(cdev->ep4_in_urb);

		if (ret < 0)

			goto exit_free_idev;



		snd_usb_caiaq_set_auto_msg(cdev, 1, 10, 5);
@@ -757,6 +760,9 @@ int snd_usb_caiaq_input_init(struct snd_usb_caiaqdev *cdev) 
				  usb_rcvbulkpipe(usb_dev, 0x4),

				  cdev->ep4_in_buf, EP4_BUFSIZE,

				  snd_usb_caiaq_ep4_reply_dispatch, cdev);

		ret = usb_urb_ep_type_check(cdev->ep4_in_urb);

		if (ret < 0)

			goto exit_free_idev;



		snd_usb_caiaq_set_auto_msg(cdev, 1, 10, 5);
@@ -802,6 +808,9 @@ int snd_usb_caiaq_input_init(struct snd_usb_caiaqdev *cdev) 
				  usb_rcvbulkpipe(usb_dev, 0x4),

				  cdev->ep4_in_buf, EP4_BUFSIZE,

				  snd_usb_caiaq_ep4_reply_dispatch, cdev);

		ret = usb_urb_ep_type_check(cdev->ep4_in_urb);

		if (ret < 0)

			goto exit_free_idev;



		snd_usb_caiaq_set_auto_msg(cdev, 1, 10, 5);

		break;