Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 969dd061 authored by Eric Sesterhenn's avatar Eric Sesterhenn Committed by Linus Torvalds
Browse files

[PATCH] Cyclades Cleanup 



coverity choked at two !tty checks, in places where tty can never be NULL.
Since it removes some code we should remove these checks.  (Coverity ids
#763,#762)

[akpm@osdl.org: even cleaner!]
Signed-off-by: default avatarEric Sesterhenn <snakebyte@gmx.de>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 2aa92581

drivers/char/cyclades.c

+3 −4
Original line number Diff line number Diff line
@@ -2833,9 +2833,8 @@ cy_write(struct tty_struct * tty, const unsigned char *buf, int count) 
        return 0;

    }

        

    if (!tty || !info->xmit_buf || !tmp_buf){

    if (!info->xmit_buf || !tmp_buf)

	return 0;

    }



    CY_LOCK(info, flags);

    while (1) {
@@ -2884,7 +2883,7 @@ cy_put_char(struct tty_struct *tty, unsigned char ch) 
    if (serial_paranoia_check(info, tty->name, "cy_put_char"))

        return;



    if (!tty || !info->xmit_buf)

    if (!info->xmit_buf)

        return;



    CY_LOCK(info, flags);