Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 963916fd authored by Kalderon, Michal's avatar Kalderon, Michal Committed by Doug Ledford
Browse files

IB/cma: Fix reference count leak when no ipv4 addresses are set 



Once in_dev_get is called to receive in_device pointer, the
in_device reference counter is increased, but if there are
no ipv4 addresses configured on the net-device the ifa_list
will be null, resulting in a flow that doesn't call in_dev_put
to decrease the ref_cnt.
This was exposed when running RoCE over ipv6 without any ipv4
addresses configured

Fixes: commit 8e3867310c90 ("IB/cma: Fix a race condition in iboe_addr_get_sgid()")

Signed-off-by: default avatarMichal Kalderon <Michal.Kalderon@cavium.com>
Signed-off-by: default avatarAriel Elior <Ariel.Elior@cavium.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent e6e52aec

include/rdma/ib_addr.h

+4 −2
Original line number Diff line number Diff line
@@ -205,11 +205,13 @@ static inline void iboe_addr_get_sgid(struct rdma_dev_addr *dev_addr, 
	dev = dev_get_by_index(&init_net, dev_addr->bound_dev_if);

	if (dev) {

		ip4 = in_dev_get(dev);

		if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address) {

		if (ip4 && ip4->ifa_list && ip4->ifa_list->ifa_address)

			ipv6_addr_set_v4mapped(ip4->ifa_list->ifa_address,

					       (struct in6_addr *)gid);



		if (ip4)

			in_dev_put(ip4);

		}



		dev_put(dev);

	}

}