Commit 9558df3a authored Jul 30, 2017 by Andrew Lunn Committed by David S. Miller Jul 30, 2017

net: fec: Issue error for missing but expected PHY



If the PHY is missing but expected, e.g. because of a typ0 in the dt
file, it is not possible to open the interface. ip link returns:

RTNETLINK answers: No such device

It is not very obvious what the problem is. Add a netdev_err() in this
case to make it easier to debug the issue.

[   21.409385] fec 2188000.ethernet eth0: Unable to connect to phy
RTNETLINK answers: No such device

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 509394e8

drivers/net/ethernet/freescale/fec_main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1904,8 +1904,10 @@ static int fec_enet_mii_probe(struct net_device *ndev)
		phy_dev = of_phy_connect(ndev, fep->phy_node,
		&fec_enet_adjust_link, 0,
		fep->phy_interface);
		if (!phy_dev)
		if (!phy_dev) {
		netdev_err(ndev, "Unable to connect to phy\n");
		return -ENODEV;
		}
		} else {
		/* check for attached phy */
		for (phy_id = 0; (phy_id < PHY_MAX_ADDR); phy_id++) {