Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 95357907 authored by Jesper Dangaard Brouer's avatar Jesper Dangaard Brouer Committed by David S. Miller
Browse files

mlx4: fix XDP_TX is acting like XDP_PASS on TX ring full 



The XDP_TX action can fail transmitting the frame in case the TX ring
is full or port is down.  In case of TX failure it should drop the
frame, and not as now call 'break' which is the same as XDP_PASS.

Fixes: 9ecc2d86 ("net/mlx4_en: add xdp forwarding and data write support")
Signed-off-by: default avatarJesper Dangaard Brouer <brouer@redhat.com>
Reviewed-by: default avatarBrenden Blanco <bblanco@plumgrid.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8ddda653

drivers/net/ethernet/mellanox/mlx4/en_rx.c

+1 −1
Original line number Diff line number Diff line
@@ -906,7 +906,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud 
							length, tx_index,

							&doorbell_pending))

					goto consumed;

				break;

				goto next; /* Drop on xmit failure */

			default:

				bpf_warn_invalid_xdp_action(act);

			case XDP_ABORTED: