Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94cdc560 authored by Dan Carpenter's avatar Dan Carpenter Committed by Guenter Roeck
Browse files

hwmon: (max31790) potential ERR_PTR dereference 



We should only dereference "data" after we check if it is an error
pointer.

Fixes: 54187ff9 ('hwmon: (max31790) Convert to use new hwmon registration API')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 667f4bab

drivers/hwmon/max31790.c

+3 −1
Original line number Diff line number Diff line
@@ -268,11 +268,13 @@ static int max31790_read_pwm(struct device *dev, u32 attr, int channel, 
			     long *val)

{

	struct max31790_data *data = max31790_update_device(dev);

	u8 fan_config = data->fan_config[channel];

	u8 fan_config;



	if (IS_ERR(data))

		return PTR_ERR(data);



	fan_config = data->fan_config[channel];



	switch (attr) {

	case hwmon_pwm_input:

		*val = data->pwm[channel] >> 8;