Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94bfaafa authored by Jian Shen's avatar Jian Shen Committed by David S. Miller
Browse files

net: hns3: Fix a loop index error of tqp statistics query 



An error loop index was used while querying statistics data
of tqps, which may cause call trace.

Fixes: 496d03e9 ("net: hns3: Add Ethtool support to HNS3 driver")
Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d2a5dca8

drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c

+5 −5
Original line number Diff line number Diff line
@@ -458,13 +458,13 @@ static u64 *hns3_get_stats_tqps(struct hnae3_handle *handle, u64 *data) 
	struct hnae3_knic_private_info *kinfo = &handle->kinfo;

	struct hns3_enet_ring *ring;

	u8 *stat;

	u32 i;

	int i, j;



	/* get stats for Tx */

	for (i = 0; i < kinfo->num_tqps; i++) {

		ring = nic_priv->ring_data[i].ring;

		for (i = 0; i < HNS3_TXQ_STATS_COUNT; i++) {

			stat = (u8 *)ring + hns3_txq_stats[i].stats_offset;

		for (j = 0; j < HNS3_TXQ_STATS_COUNT; j++) {

			stat = (u8 *)ring + hns3_txq_stats[j].stats_offset;

			*data++ = *(u64 *)stat;

		}

	}
@@ -472,8 +472,8 @@ static u64 *hns3_get_stats_tqps(struct hnae3_handle *handle, u64 *data) 
	/* get stats for Rx */

	for (i = 0; i < kinfo->num_tqps; i++) {

		ring = nic_priv->ring_data[i + kinfo->num_tqps].ring;

		for (i = 0; i < HNS3_RXQ_STATS_COUNT; i++) {

			stat = (u8 *)ring + hns3_rxq_stats[i].stats_offset;

		for (j = 0; j < HNS3_RXQ_STATS_COUNT; j++) {

			stat = (u8 *)ring + hns3_rxq_stats[j].stats_offset;

			*data++ = *(u64 *)stat;

		}

	}