Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 941f8960 authored by Andrzej Pietrasiewicz's avatar Andrzej Pietrasiewicz Committed by Mauro Carvalho Chehab
Browse files

[media] v4l2: vb2-dma-sg: fix potential security hole 



Memory allocated by alloc_page() function might contain some potentially
important data from other system processes. The patch adds a flag to
zero the allocated page before giving it to videobuf2 (and then to
userspace).

Signed-off-by: default avatarAndrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 72f1fc33

drivers/media/video/videobuf2-dma-sg.c

+1 −1
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ static void *vb2_dma_sg_alloc(void *alloc_ctx, unsigned long size) 
		goto fail_pages_array_alloc;



	for (i = 0; i < buf->sg_desc.num_pages; ++i) {

		buf->pages[i] = alloc_page(GFP_KERNEL);

		buf->pages[i] = alloc_page(GFP_KERNEL | __GFP_ZERO);

		if (NULL == buf->pages[i])

			goto fail_pages_alloc;

		sg_set_page(&buf->sg_desc.sglist[i],