Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9360ffd1 authored by David S. Miller's avatar David S. Miller
Browse files

wireless: Stop using NLA_PUT*(). 



These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d0fde795

net/wireless/nl80211.c

+660 −544

File changed.

Preview size limit exceeded, changes collapsed.

net/wireless/wext-core.c

+2 −1
Original line number Diff line number Diff line
@@ -402,7 +402,8 @@ static struct nlmsghdr *rtnetlink_ifinfo_prep(struct net_device *dev, 
	r->ifi_flags = dev_get_flags(dev);

	r->ifi_change = 0;	/* Wireless changes don't affect those flags */



	NLA_PUT_STRING(skb, IFLA_IFNAME, dev->name);

	if (nla_put_string(skb, IFLA_IFNAME, dev->name))

		goto nla_put_failure;



	return nlh;

 nla_put_failure: