Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9349923d authored by Joseph Gruher's avatar Joseph Gruher Committed by James Bottomley
Browse files

[SCSI] scsi_dh_alua: fix stpg_endio group state reporting 



Initialize stpg_endio() 'err' to SCSI_DH_OK and only change it to
SCSI_DH_IO accordingly.  This allows the switching of target group state
to be properly reported when no error has occurred.

Signed-off-by: default avatarJoseph Gruher <joseph.r.gruher@intel.com>
Signed-off-by: default avatarIlgu Hong <ilgu.hong@promise.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent ed0f36bc

drivers/scsi/device_handler/scsi_dh_alua.c

+5 −3
Original line number Diff line number Diff line
@@ -253,13 +253,15 @@ static void stpg_endio(struct request *req, int error) 
{

	struct alua_dh_data *h = req->end_io_data;

	struct scsi_sense_hdr sense_hdr;

	unsigned err = SCSI_DH_IO;

	unsigned err = SCSI_DH_OK;



	if (error || host_byte(req->errors) != DID_OK ||

			msg_byte(req->errors) != COMMAND_COMPLETE)

			msg_byte(req->errors) != COMMAND_COMPLETE) {

		err = SCSI_DH_IO;

		goto done;

	}



	if (err == SCSI_DH_IO && h->senselen > 0) {

	if (h->senselen > 0) {

		err = scsi_normalize_sense(h->sense, SCSI_SENSE_BUFFERSIZE,

					   &sense_hdr);

		if (!err) {