Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92e1d5be authored by Arjan van de Ven's avatar Arjan van de Ven Committed by Linus Torvalds
Browse files

[PATCH] mark struct inode_operations const 2 



Many struct inode_operations in the kernel can be "const".  Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data.  In addition it'll catch accidental writes at compile time to
these shared resources.

Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 754661f1

fs/gfs2/ops_inode.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -1115,7 +1115,7 @@ static int gfs2_removexattr(struct dentry *dentry, const char *name) 
	return gfs2_ea_remove(GFS2_I(dentry->d_inode), &er);

	return gfs2_ea_remove(GFS2_I(dentry->d_inode), &er);

}

}





struct inode_operations gfs2_file_iops = {

const struct inode_operations gfs2_file_iops = {

	.permission = gfs2_permission,

	.permission = gfs2_permission,

	.setattr = gfs2_setattr,

	.setattr = gfs2_setattr,

	.getattr = gfs2_getattr,

	.getattr = gfs2_getattr,
@@ -1125,7 +1125,7 @@ struct inode_operations gfs2_file_iops = { 
	.removexattr = gfs2_removexattr,

	.removexattr = gfs2_removexattr,

};

};





struct inode_operations gfs2_dev_iops = {

const struct inode_operations gfs2_dev_iops = {

	.permission = gfs2_permission,

	.permission = gfs2_permission,

	.setattr = gfs2_setattr,

	.setattr = gfs2_setattr,

	.getattr = gfs2_getattr,

	.getattr = gfs2_getattr,
@@ -1135,7 +1135,7 @@ struct inode_operations gfs2_dev_iops = { 
	.removexattr = gfs2_removexattr,

	.removexattr = gfs2_removexattr,

};

};





struct inode_operations gfs2_dir_iops = {

const struct inode_operations gfs2_dir_iops = {

	.create = gfs2_create,

	.create = gfs2_create,

	.lookup = gfs2_lookup,

	.lookup = gfs2_lookup,

	.link = gfs2_link,

	.link = gfs2_link,
@@ -1154,7 +1154,7 @@ struct inode_operations gfs2_dir_iops = { 
	.removexattr = gfs2_removexattr,

	.removexattr = gfs2_removexattr,

};

};





struct inode_operations gfs2_symlink_iops = {

const struct inode_operations gfs2_symlink_iops = {

	.readlink = gfs2_readlink,

	.readlink = gfs2_readlink,

	.follow_link = gfs2_follow_link,

	.follow_link = gfs2_follow_link,

	.permission = gfs2_permission,

	.permission = gfs2_permission,

fs/gfs2/ops_inode.h

+4 −4
Original line number Original line Diff line number Diff line
@@ -12,9 +12,9 @@ 




#include <linux/fs.h>

#include <linux/fs.h>





extern struct inode_operations gfs2_file_iops;

extern const struct inode_operations gfs2_file_iops;

extern struct inode_operations gfs2_dir_iops;

extern const struct inode_operations gfs2_dir_iops;

extern struct inode_operations gfs2_symlink_iops;

extern const struct inode_operations gfs2_symlink_iops;

extern struct inode_operations gfs2_dev_iops;

extern const struct inode_operations gfs2_dev_iops;





#endif /* __OPS_INODE_DOT_H__ */
 
#endif /* __OPS_INODE_DOT_H__ */

fs/hfs/dir.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -320,7 +320,7 @@ const struct file_operations hfs_dir_operations = { 
	.release	= hfs_dir_release,

	.release	= hfs_dir_release,

};

};





struct inode_operations hfs_dir_inode_operations = {

const struct inode_operations hfs_dir_inode_operations = {

	.create		= hfs_create,

	.create		= hfs_create,

	.lookup		= hfs_lookup,

	.lookup		= hfs_lookup,

	.unlink		= hfs_unlink,

	.unlink		= hfs_unlink,

fs/hfs/hfs_fs.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -170,7 +170,7 @@ extern void hfs_cat_build_key(struct super_block *, btree_key *, u32, struct qst 




/* dir.c */

/* dir.c */

extern const struct file_operations hfs_dir_operations;

extern const struct file_operations hfs_dir_operations;

extern struct inode_operations hfs_dir_inode_operations;

extern const struct inode_operations hfs_dir_inode_operations;





/* extent.c */

/* extent.c */

extern int hfs_ext_keycmp(const btree_key *, const btree_key *);

extern int hfs_ext_keycmp(const btree_key *, const btree_key *);

fs/hfs/inode.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -18,7 +18,7 @@ 
#include "btree.h"

#include "btree.h"





static const struct file_operations hfs_file_operations;

static const struct file_operations hfs_file_operations;

static struct inode_operations hfs_file_inode_operations;

static const struct inode_operations hfs_file_inode_operations;





/*================ Variable-like macros ================*/

/*================ Variable-like macros ================*/
@@ -612,7 +612,7 @@ static const struct file_operations hfs_file_operations = { 
	.release	= hfs_file_release,

	.release	= hfs_file_release,

};

};





static struct inode_operations hfs_file_inode_operations = {

static const struct inode_operations hfs_file_inode_operations = {

	.lookup		= hfs_file_lookup,

	.lookup		= hfs_file_lookup,

	.truncate	= hfs_file_truncate,

	.truncate	= hfs_file_truncate,

	.setattr	= hfs_inode_setattr,

	.setattr	= hfs_inode_setattr,