Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9244e838 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Greg Kroah-Hartman
Browse files

ALSA; firewire-tascam: exclude Tascam FE-8 from detection 



Tascam FE-8 is known to support communication by asynchronous transaction
only. The support can be implemented in userspace application and
snd-firewire-ctl-services project has the support. However, ALSA
firewire-tascam driver is bound to the model.

This commit changes device entries so that the model is excluded. In a
commit 53b3ffee ("ALSA: firewire-tascam: change device probing
processing"), I addressed to the concern that version field in
configuration differs depending on installed firmware. However, as long
as I checked, the version number is fixed. It's safe to return version
number back to modalias.

Fixes: 53b3ffee ("ALSA: firewire-tascam: change device probing processing")
Cc: <stable@vger.kernel.org> # 4.4+
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20200823075537.56255-1-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 67957f12

sound/firewire/tascam/tascam.c

+29 −1
Original line number Diff line number Diff line
@@ -225,11 +225,39 @@ static void snd_tscm_remove(struct fw_unit *unit) 
}



static const struct ieee1394_device_id snd_tscm_id_table[] = {

	// Tascam, FW-1884.

	{

		.match_flags = IEEE1394_MATCH_VENDOR_ID |

			       IEEE1394_MATCH_SPECIFIER_ID,

			       IEEE1394_MATCH_SPECIFIER_ID |

			       IEEE1394_MATCH_VERSION,

		.vendor_id = 0x00022e,

		.specifier_id = 0x00022e,

		.version = 0x800000,

	},

	// Tascam, FE-8 (.version = 0x800001)

	// This kernel module doesn't support FE-8 because the most of features

	// can be implemented in userspace without any specific support of this

	// module.

	//

	// .version = 0x800002 is unknown.

	//

	// Tascam, FW-1082.

	{

		.match_flags = IEEE1394_MATCH_VENDOR_ID |

			       IEEE1394_MATCH_SPECIFIER_ID |

			       IEEE1394_MATCH_VERSION,

		.vendor_id = 0x00022e,

		.specifier_id = 0x00022e,

		.version = 0x800003,

	},

	// Tascam, FW-1804.

	{

		.match_flags = IEEE1394_MATCH_VENDOR_ID |

			       IEEE1394_MATCH_SPECIFIER_ID |

			       IEEE1394_MATCH_VERSION,

		.vendor_id = 0x00022e,

		.specifier_id = 0x00022e,

		.version = 0x800004,

	},

	/* FE-08 requires reverse-engineering because it just has faders. */

	{}