Commit 92190e36 authored Jan 24, 2017 by Augusto Mecking Caringi Committed by Greg Kroah-Hartman Jan 25, 2017

usb: storage: sddr09: Remove a set-but-not-used variable



The 'isnew' variable in 'sddr09_write_lba' function is set but never
used.

This has been detected by building the driver with W=1:

drivers/usb/storage/sddr09.c: In function ‘sddr09_write_lba’:
drivers/usb/storage/sddr09.c:873:17: warning: variable ‘isnew’ set but
not used [-Wunused-but-set-variable]
int i, result, isnew;
                 ^

Signed-off-by: Augusto Mecking Caringi <augustocaringi@gmail.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1e572aa5

drivers/usb/storage/sddr09.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -870,13 +870,12 @@ sddr09_write_lba(struct us_data *us, unsigned int lba,
		unsigned int pagelen;
		unsigned char bptr, cptr, *xptr;
		unsigned char ecc[3];
		int i, result, isnew;
		int i, result;

		lbap = ((lba % 1000) << 1) \| 0x1000;
		if (parity[MSB_of(lbap) ^ LSB_of(lbap)])
		lbap ^= 1;
		pba = info->lba_to_pba[lba];
		isnew = 0;

		if (pba == UNDEF) {
		pba = sddr09_find_unused_pba(info, lba);
		@@ -887,7 +886,6 @@ sddr09_write_lba(struct us_data *us, unsigned int lba,
		}
		info->pba_to_lba[pba] = lba;
		info->lba_to_pba[lba] = pba;
		isnew = 1;
		}

		if (pba == 1) {