Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91f9943e authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Al Viro
Browse files

fs: support RWF_NOWAIT for buffered reads 



This is based on the old idea and code from Milosz Tanski.  With the aio
nowait code it becomes mostly trivial now.  Buffered writes continue to
return -EOPNOTSUPP if RWF_NOWAIT is passed.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 3239d834

fs/aio.c

+0 −6
Original line number Diff line number Diff line
@@ -1593,12 +1593,6 @@ static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb, 
		goto out_put_req;

	}



	if ((req->common.ki_flags & IOCB_NOWAIT) &&

			!(req->common.ki_flags & IOCB_DIRECT)) {

		ret = -EOPNOTSUPP;

		goto out_put_req;

	}



	ret = put_user(KIOCB_KEY, &user_iocb->aio_key);

	if (unlikely(ret)) {

		pr_debug("EFAULT: aio_key\n");

fs/btrfs/file.c

+5 −1
Original line number Diff line number Diff line
@@ -1886,6 +1886,10 @@ static ssize_t btrfs_file_write_iter(struct kiocb *iocb, 
	loff_t oldsize;

	int clean_page = 0;



	if (!(iocb->ki_flags & IOCB_DIRECT) &&

	    (iocb->ki_flags & IOCB_NOWAIT))

		return -EOPNOTSUPP;



	if (!inode_trylock(inode)) {

		if (iocb->ki_flags & IOCB_NOWAIT)

			return -EAGAIN;
@@ -3105,7 +3109,7 @@ static loff_t btrfs_file_llseek(struct file *file, loff_t offset, int whence) 


static int btrfs_file_open(struct inode *inode, struct file *filp)

{

	filp->f_mode |= FMODE_AIO_NOWAIT;

	filp->f_mode |= FMODE_NOWAIT;

	return generic_file_open(inode, filp);

}

fs/ext4/file.c

+3 −3
Original line number Diff line number Diff line
@@ -223,6 +223,8 @@ ext4_file_write_iter(struct kiocb *iocb, struct iov_iter *from) 
	if (IS_DAX(inode))

		return ext4_dax_write_iter(iocb, from);

#endif

	if (!o_direct && (iocb->ki_flags & IOCB_NOWAIT))

		return -EOPNOTSUPP;



	if (!inode_trylock(inode)) {

		if (iocb->ki_flags & IOCB_NOWAIT)
@@ -448,9 +450,7 @@ static int ext4_file_open(struct inode * inode, struct file * filp) 
			return ret;

	}



	/* Set the flags to support nowait AIO */

	filp->f_mode |= FMODE_AIO_NOWAIT;



	filp->f_mode |= FMODE_NOWAIT;

	return dquot_file_open(inode, filp);

}

fs/xfs/xfs_file.c

+9 −2
Original line number Diff line number Diff line
@@ -259,7 +259,11 @@ xfs_file_buffered_aio_read( 


	trace_xfs_file_buffered_read(ip, iov_iter_count(to), iocb->ki_pos);



	if (!xfs_ilock_nowait(ip, XFS_IOLOCK_SHARED)) {

		if (iocb->ki_flags & IOCB_NOWAIT)

			return -EAGAIN;

		xfs_ilock(ip, XFS_IOLOCK_SHARED);

	}

	ret = generic_file_read_iter(iocb, to);

	xfs_iunlock(ip, XFS_IOLOCK_SHARED);
@@ -636,6 +640,9 @@ xfs_file_buffered_aio_write( 
	int			enospc = 0;

	int			iolock;



	if (iocb->ki_flags & IOCB_NOWAIT)

		return -EOPNOTSUPP;



write_retry:

	iolock = XFS_IOLOCK_EXCL;

	xfs_ilock(ip, iolock);
@@ -912,7 +919,7 @@ xfs_file_open( 
		return -EFBIG;

	if (XFS_FORCED_SHUTDOWN(XFS_M(inode->i_sb)))

		return -EIO;

	file->f_mode |= FMODE_AIO_NOWAIT;

	file->f_mode |= FMODE_NOWAIT;

	return 0;

}

include/linux/fs.h

+3 −3
Original line number Diff line number Diff line
@@ -146,8 +146,8 @@ typedef int (dio_iodone_t)(struct kiocb *iocb, loff_t offset, 
/* File was opened by fanotify and shouldn't generate fanotify events */

#define FMODE_NONOTIFY		((__force fmode_t)0x4000000)



/* File is capable of returning -EAGAIN if AIO will block */

#define FMODE_AIO_NOWAIT	((__force fmode_t)0x8000000)

/* File is capable of returning -EAGAIN if I/O will block */

#define FMODE_NOWAIT	((__force fmode_t)0x8000000)



/*

 * Flag for rw_copy_check_uvector and compat_rw_copy_check_uvector
@@ -3149,7 +3149,7 @@ static inline int kiocb_set_rw_flags(struct kiocb *ki, int flags) 
		return -EOPNOTSUPP;



	if (flags & RWF_NOWAIT) {

		if (!(ki->ki_filp->f_mode & FMODE_AIO_NOWAIT))

		if (!(ki->ki_filp->f_mode & FMODE_NOWAIT))

			return -EOPNOTSUPP;

		ki->ki_flags |= IOCB_NOWAIT;

	}