Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 911a359d authored by Richard Cochran's avatar Richard Cochran Committed by Ingo Molnar
Browse files

leds/trigger/cpu: Convert to hotplug state machine 



This is a straightforward conversion. We place this callback last
in the list so that the LED illuminates only after a successful
bring up sequence.

( NOTE: The patch adds a FIXME question about the callback used,
        this question should probably be revisited later on.)

Signed-off-by: default avatarRichard Cochran <rcochran@linutronix.de>
Signed-off-by: default avatarAnna-Maria Gleixner <anna-maria@linutronix.de>
Reviewed-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-leds@vger.kernel.org
Cc: rt@linutronix.de
Link: http://lkml.kernel.org/r/20160713153336.465496902@linutronix.de


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 2dab9093

drivers/leds/trigger/ledtrig-cpu.c

+15 −17
Original line number Diff line number Diff line
@@ -92,26 +92,18 @@ static struct syscore_ops ledtrig_cpu_syscore_ops = { 
	.resume		= ledtrig_cpu_syscore_resume,

};



static int ledtrig_cpu_notify(struct notifier_block *self,

					   unsigned long action, void *hcpu)

static int ledtrig_starting_cpu(unsigned int cpu)

{

	switch (action & ~CPU_TASKS_FROZEN) {

	case CPU_STARTING:

	ledtrig_cpu(CPU_LED_START);

		break;

	case CPU_DYING:

		ledtrig_cpu(CPU_LED_STOP);

		break;

	return 0;

}



	return NOTIFY_OK;

static int ledtrig_dying_cpu(unsigned int cpu)

{

	ledtrig_cpu(CPU_LED_STOP);

	return 0;

}





static struct notifier_block ledtrig_cpu_nb = {

	.notifier_call = ledtrig_cpu_notify,

};



static int __init ledtrig_cpu_init(void)

{

	int cpu;
@@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) 
	}



	register_syscore_ops(&ledtrig_cpu_syscore_ops);

	register_cpu_notifier(&ledtrig_cpu_nb);



	/*

	 * FIXME: Why needs this to happen in the interrupt disabled

	 * low level bringup phase of a cpu?

	 */

	cpuhp_setup_state(CPUHP_AP_LEDTRIG_STARTING, "AP_LEDTRIG_STARTING",

			  ledtrig_starting_cpu, ledtrig_dying_cpu);



	pr_info("ledtrig-cpu: registered to indicate activity on CPUs\n");

include/linux/cpuhotplug.h

+1 −0
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ enum cpuhp_state { 
	CPUHP_AP_QCOM_TIMER_STARTING,

	CPUHP_AP_MIPS_GIC_TIMER_STARTING,

	CPUHP_AP_KVM_STARTING,

	CPUHP_AP_LEDTRIG_STARTING,

	CPUHP_AP_NOTIFY_STARTING,

	CPUHP_AP_ONLINE,

	CPUHP_TEARDOWN_CPU,