Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90fcc898 authored by Clemens Ladisch's avatar Clemens Ladisch Committed by Stefan Richter
Browse files

firewire: ohci: optimize control bit checks 



Doing the endian conversion on the constant instead of the memory
field allows the compiler to do the conversion at compile time.

Signed-off-by: default avatarClemens Ladisch <clemens@ladisch.de>
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent b9b5bbfd

drivers/firewire/ohci.c

+3 −3
Original line number Diff line number Diff line
@@ -2728,7 +2728,7 @@ static int handle_ir_packet_per_buffer(struct context *context, 
	p = last + 1;

	copy_iso_headers(ctx, p);



	if (le16_to_cpu(last->control) & DESCRIPTOR_IRQ_ALWAYS) {

	if (last->control & cpu_to_le16(DESCRIPTOR_IRQ_ALWAYS)) {

		ir_header = (__le32 *) p;

		ctx->base.callback.sc(&ctx->base,

				      le32_to_cpu(ir_header[0]) & 0xffff,
@@ -2760,7 +2760,7 @@ static int handle_ir_buffer_fill(struct context *context, 
				      le16_to_cpu(last->req_count),

				      DMA_FROM_DEVICE);



	if (le16_to_cpu(last->control) & DESCRIPTOR_IRQ_ALWAYS)

	if (last->control & cpu_to_le16(DESCRIPTOR_IRQ_ALWAYS))

		ctx->base.callback.mc(&ctx->base,

				      le32_to_cpu(last->data_address) +

				      le16_to_cpu(last->req_count),
@@ -2832,7 +2832,7 @@ static int handle_it_packet(struct context *context, 
				le16_to_cpu(pd->res_count));

		ctx->header_length += 4;

	}

	if (le16_to_cpu(last->control) & DESCRIPTOR_IRQ_ALWAYS) {

	if (last->control & cpu_to_le16(DESCRIPTOR_IRQ_ALWAYS)) {

		ctx->base.callback.sc(&ctx->base, le16_to_cpu(last->res_count),

				      ctx->header_length, ctx->header,

				      ctx->base.callback_data);