Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90f2409c authored by Douglas Anderson's avatar Douglas Anderson Committed by Greg Kroah-Hartman
Browse files

kdb: Use the passed prompt in kdb_position_cursor() 



[ Upstream commit e2e821095949cde46256034975a90f88626a2a73 ]

The function kdb_position_cursor() takes in a "prompt" parameter but
never uses it. This doesn't _really_ matter since all current callers
of the function pass the same value and it's a global variable, but
it's a bit ugly. Let's clean it up.

Found by code inspection. This patch is expected to functionally be a
no-op.

Fixes: 09b35989421d ("kdb: Use format-strings rather than '\0' injection in kdb_read()")
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20240528071144.1.I0feb49839c6b6f4f2c4bf34764f5e95de3f55a66@changeid


Signed-off-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 22a10055

kernel/debug/kdb/kdb_io.c

+1 −1
Original line number Diff line number Diff line
@@ -192,7 +192,7 @@ static int kdb_read_get_key(char *buffer, size_t bufsize) 
 */

static void kdb_position_cursor(char *prompt, char *buffer, char *cp)

{

	kdb_printf("\r%s", kdb_prompt_str);

	kdb_printf("\r%s", prompt);

	if (cp > buffer)

		kdb_printf("%.*s", (int)(cp - buffer), buffer);

}