Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90718e32 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Ingo Molnar
Browse files

uprobes/x86: Remove incorrect WARN_ON() in uprobe_init_insn() 



insn_get_length() has the side-effect of processing the entire instruction
but only if it was decoded successfully, otherwise insn_complete() can fail
and in this case we need to just return an error without warning.

Reported-by: default avatar <syzbot+30d675e3ca03c1c351e7@syzkaller.appspotmail.com>
Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Reviewed-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: syzkaller-bugs@googlegroups.com
Link: https://lkml.kernel.org/lkml/20180518162739.GA5559@redhat.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent a89d0c2a

arch/x86/kernel/uprobes.c

+1 −1
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ static int uprobe_init_insn(struct arch_uprobe *auprobe, struct insn *insn, bool 
	insn_init(insn, auprobe->insn, sizeof(auprobe->insn), x86_64);

	/* has the side-effect of processing the entire instruction */

	insn_get_length(insn);

	if (WARN_ON_ONCE(!insn_complete(insn)))

	if (!insn_complete(insn))

		return -ENOEXEC;



	if (is_prefix_bad(insn))