Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fb88201 authored by John Garry's avatar John Garry Committed by Martin K. Petersen
Browse files

hisi_sas: Fix typo in setup_itct_v1_hw() 



We were doing a arithmetic comparison instead of logical shift by
accident.  Mis-programming the itct did not seem to make a difference to
operation.

Fixes: abda97c2 ("hisi_sas: Add dev_found")

Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Reviewed-by: default avatarMatthew R. Ochs <mrochs@linux.vnet.ibm.com>
Reviewed-by: default avatarShane Seymour <shane.seymour@hpe.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8ceec332

drivers/scsi/hisi_sas/hisi_sas_v1_hw.c

+4 −4
Original line number Diff line number Diff line
@@ -528,10 +528,10 @@ static void setup_itct_v1_hw(struct hisi_hba *hisi_hba, 
	itct->sas_addr = __swab64(itct->sas_addr);



	/* qw2 */

	itct->qw2 = cpu_to_le64((500 < ITCT_HDR_IT_NEXUS_LOSS_TL_OFF) |

				(0xff00 < ITCT_HDR_BUS_INACTIVE_TL_OFF) |

				(0xff00 < ITCT_HDR_MAX_CONN_TL_OFF) |

				(0xff00 < ITCT_HDR_REJ_OPEN_TL_OFF));

	itct->qw2 = cpu_to_le64((500ULL << ITCT_HDR_IT_NEXUS_LOSS_TL_OFF) |

				(0xff00ULL << ITCT_HDR_BUS_INACTIVE_TL_OFF) |

				(0xff00ULL << ITCT_HDR_MAX_CONN_TL_OFF) |

				(0xff00ULL << ITCT_HDR_REJ_OPEN_TL_OFF));

}



static void free_device_v1_hw(struct hisi_hba *hisi_hba,