Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f451829 authored by Varka Bhadram's avatar Varka Bhadram Committed by Marcel Holtmann
Browse files

mac802154: use WARN_ON() macro 



This patch will generate the warning if the required driver ops
were not defined. Also it removes unnecessary debug message.

Signed-off-by: default avatarVarka Bhadram <varkab@cdac.in>
Acked-by: default avatarAlexander Aring <alex.aring@gmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 301d7d42

net/mac802154/main.c

+2 −4
Original line number Diff line number Diff line
@@ -58,11 +58,9 @@ ieee802154_alloc_hw(size_t priv_data_len, const struct ieee802154_ops *ops) 
	struct ieee802154_local *local;

	size_t priv_size;



	if (!ops || !(ops->xmit_async || ops->xmit_sync) || !ops->ed ||

	    !ops->start || !ops->stop || !ops->set_channel) {

		pr_err("undefined IEEE802.15.4 device operations\n");

	if (WARN_ON(!ops || !(ops->xmit_async || ops->xmit_sync) || !ops->ed ||

		    !ops->start || !ops->stop || !ops->set_channel))

		return NULL;

	}



	/* Ensure 32-byte alignment of our private data and hw private data.

	 * We use the wpan_phy priv data for both our ieee802154_local and for