Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e8a2dea authored by Zygo Blaxell's avatar Zygo Blaxell Committed by Linus Torvalds
Browse files

lib/genalloc.c: remove unmatched write_lock() in gen_pool_destroy 



There is a call to write_lock() in gen_pool_destroy which is not balanced
by any corresponding write_unlock().  This causes problems with preemption
because the preemption-disable counter is incremented in the write_lock()
call, but never decremented by any call to write_unlock().  This bug is
gen_pool_destroy, and one of them is non-x86 arch-specific code.

Signed-off-by: default avatarZygo Blaxell <zygo.blaxell@xandros.com>
Cc: Jiri Kosina <trivial@kernel.org>
Cc: Steve Wise <swise@opengridcomputing.com>
Cc: <stable@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 69050eee

lib/genalloc.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -85,7 +85,6 @@ void gen_pool_destroy(struct gen_pool *pool) 
	int bit, end_bit;

	int bit, end_bit;









	write_lock(&pool->lock);

	list_for_each_safe(_chunk, _next_chunk, &pool->chunks) {

	list_for_each_safe(_chunk, _next_chunk, &pool->chunks) {

		chunk = list_entry(_chunk, struct gen_pool_chunk, next_chunk);

		chunk = list_entry(_chunk, struct gen_pool_chunk, next_chunk);

		list_del(&chunk->next_chunk);

		list_del(&chunk->next_chunk);